一次創(chuàng)建多個對象并添加到 manytomany 字段

Optimize Serializer's "create" function

keyword:
bulk_create
manytomany.add(list)

Define in a SuperSerializer
The sub serializer inherit create def and get the current model by self.Meta.model
The Model of manytomany field can be retrieve by instance.<manytomany filed name>.model

Create multiple objects and all them to a manytomany fields in one line

  1. This function included SQL in for, which easy to crash when list is too long
  2. Create multiple entries at a time is much more efficient with bulk_create.()

class CommonInfoSerializer(serializers.ModelSerializer):
    class Meta:
        abstract = True

    def create(self, validated_data):
        tags_data = validated_data.pop('tags')
    
        info_model = self.Meta.model
        instance = info_model.objects.create(**validated_data)
        tag_model = instance.tags.model
    
        for tag_data in tags_data:
            tag_name = tag_data.get('name').lower()
            try:
                tag = tag_model.objects.get(name=tag_name)
            except tag_model.DoesNotExist:
                tag = tag_model.objects.create(**tag_data)
                # tag = Tag.objects.create(name=tag_data["name"])
                tag.save()
            instance.tags.add(tag)
    
        return instance

After refactoring:

class CommonInfoSerializer(serializers.ModelSerializer):
    class Meta:
        abstract = True
        
    def create(self, validated_data):
        tags_data = validated_data.pop('tags')
        new_tags = [tag['name'].lower() for tag in tags_data]
    
        info_model = self.Meta.model
        instance = info_model.objects.create(**validated_data)
    
        tag_model = instance.tags.model
        exist_objs = tag_model.objects.filter(name__in=new_tags)                # QuerySet
        exist_tags = list(exist_objs.values_list('name', flat=True))            # List(String)
        to_create_tags = [tag for tag in new_tags if tag not in exist_tags]     # List(String)
        to_create_objs = [tag_model(name='%s' % i) for i in to_create_tags]     # List(Object)
        created_objs = tag_model.objects.bulk_create(to_create_objs)            # List(Object)
        to_add_objs = list(exist_objs) + created_objs                           # List(Object)
        instance.tags.add(*to_add_objs)
        return instance

A roughly test with 8 tags:

Before and after:
165ms vs 461ms

?著作權(quán)歸作者所有,轉(zhuǎn)載或內(nèi)容合作請聯(lián)系作者
【社區(qū)內(nèi)容提示】社區(qū)部分內(nèi)容疑似由AI輔助生成,瀏覽時請結(jié)合常識與多方信息審慎甄別。
平臺聲明:文章內(nèi)容(如有圖片或視頻亦包括在內(nèi))由作者上傳并發(fā)布,文章內(nèi)容僅代表作者本人觀點,簡書系信息發(fā)布平臺,僅提供信息存儲服務(wù)。

相關(guān)閱讀更多精彩內(nèi)容

  • rljs by sennchi Timeline of History Part One The Cognitiv...
    sennchi閱讀 7,835評論 0 10
  • 老人解開領(lǐng)域,將隔界石收了起來:“我叫月勢。你是叫何耀天吧?!辈⑷恿艘淮忧宕嗟臇|西給他,“這是這個世界的貨...
    日向凪閱讀 308評論 0 1
  • 日暮西山滿江紅,微風(fēng)瑟瑟入秋冬。漫步人生路,此景甚美暮。且把夕陽作一賦。人生有幾何,對酒當(dāng)高歌。今做他鄉(xiāng)客,來日入...
    悠悠流年閱讀 2,493評論 0 3
  • 許久未看綜藝,被“中餐廳”種草,被趙薇的滿瓶檸檬種草。 好看又好喝,就自己動手做咯 ...
    金魚醬羅斯閱讀 283評論 0 0
  • 前幾天的文章中提到一個姑涼,家里找關(guān)系來我們公司做內(nèi)勤,不到兩個月的時間,今天提出了辭職。 同事們瞠目結(jié)舌,感慨9...
    梓涵919閱讀 239評論 0 1

友情鏈接更多精彩內(nèi)容